Clinical-Genomics / genotype

Simple genotype comparison of VCF files
http://taboo.readthedocs.org/en/latest/
MIT License
8 stars 2 forks source link

Bugfix #33

Closed mayabrandi closed 4 years ago

mayabrandi commented 4 years ago

We compare the sets and not the ordered lists. Very important fix

How to test:

Go to hasta. Run:

Expected test outcome:

Review:

This is patch version bump because it's a fix

mayabrandi commented 4 years ago

Has been tested through cg on stage and the data was properly generated and loaded into the trending database.

The command witch was run on hasta was:

cg -c /home/proj/stage/servers/config/hasta.scilifelab.se/cg-stage.yaml upload vogue genotype -d 3000

The output lookes like this:

Skärmavbild 2020-02-04 kl  12 32 34
adrosenbaum commented 4 years ago

Nice done!

mayabrandi commented 4 years ago

Output from genotype export-sample-analysis -d 100 on hasta stage Highlighted an exaple rs number for a sample where the internal analysis (sequence key) reported TC and the MAF analysis(genotype key) reported CT. The comparison should be true, which it is. Before the bugfix it was false.

Skärmavbild 2020-02-11 kl  10 31 17
patrikgrenfeldt commented 4 years ago

deployed on hasta