Remove alchy - Githubissues

Clinical-Genomics / housekeeper

File data orchestrator

MIT License

2 stars 0 forks source link

Remove alchy #112

Closed seallard closed 1 year ago

seallard commented 1 year ago

Description

Replacing alchy with sqlalchemy in Housekeeper.

Changed

Replaced commit with session.commit
Replaced add_commit with session.add followed by session.commit
Replaced delete with session.delete
Replaced all alchy imports with sqlalchemy
The Store is now instantiated with a session, which is sent up to all the handlers.
Remove alchy in requirements.txt

Testing

How to prepare for test

[ ] ssh to hasta (depending on type of change)
[ ] install on stage: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_main -t housekeeper -b YOURBRANCH

How to test

[ ] login to ...
[ ] do ...

Expected test outcome

[ ] check that ...
[ ] Take a screenshot and attach or copy/paste the output.

Review

[ ] code approved by
[ ] tests executed by
[ ] "Merge and deploy" approved by Thanks for filling in who performed the code review and the test!

This version is a:

[ ] MINOR - when you add functionality in a backwards compatible manner

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
25 Code Smells

No Coverage information
0.0% Duplication

seallard commented 1 year ago

Deployed to stage, can retrieve tags for instance with housekeeper get tag. Deployed to production.