Closed moonso closed 4 years ago
Hi @henrikstranneheim , thanks for the review! I will adress the changes locally since it is very tedious to do it on GitHub, one commit for every applied change. So don't me mad if I resolver stuff, that means I have applied the changes manually 🛩️
Ok @barrystokman , I have adressed some stuff according to your suggestions. Thank's for the review!!
This PR cleanups test environment and adds a number of tests
It looks humongous due to the fact that the whole package is blacked.
For reviewers
The only changes to the actual code is the following:
Changes to hk code
--yes
flag need only be used once when deleting files with the CLI. (fixes #56 )python-dateutil
package is replaced by a function that parses date stringsChanges to tests
Almost all tests has been updated as well as the fixtures and how they are used. Test coverage is increased to ~84%
Changes to GitHub checks
The CI is now being executed by GitHub Actions instead of travis with a more slimmed config file. Code checks are done with
black
,flake8
and code factor .Expected outcome: The test environment should be improved and updated
Review:
This is minor version bump because there has been minor changes in the cli.