Reintroduce total number of hits in Variant and SV Variant models - Githubissues

Clinical-Genomics / loqusdbapi

A simple REST api for loqusdb

2 stars 0 forks source link

Reintroduce total number of hits in Variant and SV Variant models #26

Closed northwestwitch closed 2 years ago

northwestwitch commented 2 years ago

This PR adds | fixes:

Missing "total" key/values from "read_variant" and "read_sv" endpoints

How to test:

Launch the demo app (master branch) and run this query: curl -X GET "http://127.0.0.1:8000/variants/1_880086_T_C"-->It shouldn't return "total" key/value
Repeat from this branch and the key/value should be there

Review:

[x] Code approved by DN
[x] Tests executed by CR, DN

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 2 years ago

Master branch:

This branch:

dnil commented 2 years ago

Tested on cg-vm1. Screenshot 2022-01-14 at 14 01 45