Return loqusdb version info from / endpoint - Githubissues

Clinical-Genomics / loqusdbapi

A simple REST api for loqusdb

2 stars 0 forks source link

Return loqusdb version info from / endpoint #3

Closed northwestwitch closed 3 years ago

northwestwitch commented 3 years ago

Fix #2. This is just a suggestion and I see that my version of Black is different from yours, so feel free to edit!

Returns the loqusdb version installed together with welcome message in / endpoint.

How to prepare for test:

[x] Start app with uvicorn loqusdbapi.main:app --reload

How to test:

[x] curl -X GET "http://127.0.0.1:8000/" from another terminal

Expected outcome:

Response should contain the version of loqusdb module installed in loqusdbapi

Review:

[x] Code approved by MM
[x] Tests executed by CR
[ ] "Merge and deploy" approved by

This version is a:

[ ] MAJOR - when you make incompatible API changes
[x] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 3 years ago

northwestwitch commented 3 years ago

If it's fine with the different formatting I'd merge @moonso