Clinical-Genomics / loqusdbapi

A simple REST api for loqusdb
2 stars 0 forks source link

Provide examples to query for SVs and cases in readme file #7

Closed northwestwitch closed 3 years ago

northwestwitch commented 3 years ago

This PR adds an example on how to

How to test:

Review:

This version is a:

northwestwitch commented 3 years ago

Query for SVs:

image

Query n_cases:

image

Query one case: image

moonso commented 3 years ago

Hi! Did you try the generated docs? Run the server and go to host:port/docs, it is super nice interface to test the REST api

northwestwitch commented 3 years ago

Hi! Did you try the generated docs? Run the server and go to host:port/docs, it is super nice interface to test the REST api

Yes, I tried it and it's nice, but they don't provide an example with real parameters, just what the endpoint accepts and returns:

image

But it doesn't say how then GET request should be shaped (the actual string that you type either in the browser or in curl)

dnil commented 3 years ago

Also, I would rather say its a patch, for just extending docs? Changing that, but protest if you disagree obviously!

northwestwitch commented 3 years ago

Also, I would rather say its a patch, for just extending docs? Changing that, but protest if you disagree obviously!

Doesn't really matter, patch is good!

northwestwitch commented 3 years ago

Merged as a patch, thanks @dnil!