Clinical-Genomics / loqusdbapi

A simple REST api for loqusdb
2 stars 0 forks source link

Rename "nr_cases" to "total" in returned variant info #8

Closed northwestwitch closed 3 years ago

northwestwitch commented 3 years ago

The variant info returned by the api differers from the info returned when using loqus exe for a key --> nr_cases, that should correspond to total

See an example of returned info from both:

api: {'chrom': '1', 'observations': 1, 'families': ['recessive_trio'], 'nr_cases': 1, 'start': 879537, 'end': 879538, 'ref': 'T', 'alt': 'C', 'homozygote': 1, 'hemizygote': 0}

exe: {'alt': 'C', 'chrom': '1', 'end': 879538, 'families': ['recessive_trio'], 'hemizygote': 0, 'homozygote': 1, 'observations': 1, 'ref': 'T', 'start': 879537, 'total': 1}

I could fix this Scout easily (see https://github.com/Clinical-Genomics/scout/pull/2349#issuecomment-831847848) but perhaps we are interested in both api and exe returning the same keys??

Review:

This version is a:

northwestwitch commented 3 years ago

Tested with the same query after re-building the docker image using this branch: 🆗

image