Clinical-Genomics / microSALT

Microbial Sequence Analysis and Loci-based Typing pipeline for use on NGS WGS data.
GNU General Public License v3.0
2 stars 3 forks source link

Patching struct #103

Closed sylvinite closed 4 years ago

sylvinite commented 4 years ago

Description

The features of this PR primarily concerns internals

Summary of the changes made:

The HK delivery file means external programs can trend the results easier. No conflict with existing analysis exists.

Primary function of PR

Testing

Test routine to verify the stability of the PR:

_Verify that the results for projects ACC5551 are consistent with the results attached to AMSystem doc 1490, MicrobialWGS.xlsx Also review that the newly produced delivery file is present in the results folder, and is a valid json.

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Results for project ACC5551 are identical. Somehow the TravisCI test fails; but manual review of the logs review no errors (other than an insignificant warning about escaping characters). As such the TravisCI test has manually been considered to be passed.

Sign-offs

sylvinite commented 4 years ago

Manual review of Travis/Branch shows that automatic tests resolve successfully.