Clinical-Genomics / microSALT

Microbial Sequence Analysis and Loci-based Typing pipeline for use on NGS WGS data.
GNU General Public License v3.0
2 stars 3 forks source link

specify openjdk version #153

Closed henningonsbring closed 2 years ago

henningonsbring commented 2 years ago

This PR specifies a version of openjdk in the install script which would enable trimmomatic to run without the random fails mentioned in this issue: https://github.com/Clinical-Genomics/microSALT/issues/152

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Deploy correct branch on stage:

If starting microSALT with cg:

Test routine to verify the stability of the PR:

_Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, MicrobialWGS.xlsx

henningonsbring commented 2 years ago

Ran cg workflow microsalt start -t 717876 and it completed without a single trimmomatic crash. This specific ticket crashed before with the old openjdk version. Also I ran 31 trimmomatic runs in parallel all using 8 threads on the login node, first without changing openjdk then java crashed, after updating openjdk then all trimmomatic runs completed without any error.