Clinical-Genomics / microSALT

Microbial Sequence Analysis and Loci-based Typing pipeline for use on NGS WGS data.
GNU General Public License v3.0
2 stars 3 forks source link

What should we trend in vogue for microsalt? #156

Closed henningonsbring closed 1 year ago

henningonsbring commented 2 years ago

Trending statistics from microsalt analyses in vogue can give an insight into the quality of the lab work performed by Clinical genomics. We need to decide which metrics to monitor.

The metrics that matters when we deliver data to the customers:

What I suggest we trend:

Data shown by vogue won't say much about the quality of our work at Clinical genomics, basically all metrics are affected by what the customer write when they make the order. If a customer write wrong species, or submit a contaminated sample, then coverage will be low and the typing will fail.

The only important metric I can think off that we fully control if we reach the ordered number of reads or not for the samples. The customers that order MWR usually order well known patogens with support for typing by the pubMLST database, that also will be easy to type with MALDI-TOF. Therefore, the reference from start tend to be correct and vary less for the MWR-orders. For the research app tags the effort is very low when it comes to guess what species that is submitted. Because of this I suggest 10x coverage and successful typing is only tracked for MWR app tags.

Is it possible to only track metrics for a certain app tag? What do you think about my suggestion regarding metrics to pay attention to? @moahaegglund @talnor @karlnyr @Vince-janv @Karl-Svard @keyvanelhami

This issue can be closed when we have agreed on what metrics we should pay extra attention for monitoring the quality of microsalt orders over time.

karlnyr commented 2 years ago

I agree with these metrics! If we are including success rate if typing we may also include frequency of novel/unknown allele types per sample? Else, are you only going to look for the "Godkänd" criterium?

henningonsbring commented 2 years ago

I agree with these metrics! If we are including success rate if typing we may also include frequency of novel/unknown allele types per sample? Else, are you only going to look for the "Godkänd" criterium?

I agree, if we can extract information regarding how many novel alleles we find over time that would be highly relevant as a complement to the success rate for typing.

henningonsbring commented 2 years ago
Screenshot 2022-03-01 at 10 35 17

"If typing was successful for MWR app tags" can be more clearly defined by "Was the 'tröskelvärden' = 'Godkända'"

If the "Tröskelvärden" pass is better than looking at if a strain type could be assigned since this is not affected by if it is a novel strain or not.

talnor commented 2 years ago

Sounds great! It sounds like a good idea to have the option of splitting the data by apptag as you suggest.

Regarding the metrics some of them are present in vouge already. Number of reads i don't think is added by microSALT at least. Would be good to have a look at what we have now and define what we think is missing.

henningonsbring commented 2 years ago

Summary, so far we agreed on that it would be optimal to trend these indicators: 1) Fraction of samples that get the ordered number of reads 2) 10x coverage for MWR app tags 3) The fraction of samples with passed ("Godkända") thresholds ("Tröskelvärlden") for typing among MWR app tags

We already have a few indicators that are similar to 1-3 that we can look at for now, or that might even be good enough: 1) Total reads over time 2) Coverage 10x for passed samples 3) Passed vs Failed Typing Over Time

talnor commented 2 years ago

Perfect! I think we can make an issue for the suggested improvements. Then it can be picked up when we have more developers working on Vogue.

pbiology commented 1 year ago

Continued in Clinical-Genomics/CG-JASEN#6