Clinical-Genomics / microSALT

Microbial Sequence Analysis and Loci-based Typing pipeline for use on NGS WGS data.
GNU General Public License v3.0
2 stars 3 forks source link

Fix percentage of ordered reads in QC-report #81

Closed talnor closed 4 years ago

talnor commented 4 years ago

Description

The features of this PR primarily concerns end-users/bioinformaticians/internals

The percentage of ordered reads in the 'Antal Reads' column of the QC-report showed incorrect numbers. This was due to reads vs. read pairs confusion regarding the information in the apptags.

The percentage of ordered reads will now be divided by 2.

Primary function of PR

Testing

This is a description of the tests necessary to verify the stability of the PR.

Basic test routine:

Verify that the percentage of ordered reads is correct (i.e. equals the total reads / 610^6 100). Also verify that the code changes doesn't generate any unexpected error messages or graphical glitches in the report.

Test results

All percentages calculated correctly. See results below. No error messages or glitches to report.

Sign-offs

talnor commented 4 years ago

MicroSALT QC-report results Screen Shot 2019-12-03 at 4 40 41 PM

Calculations:

Screen Shot 2019-12-03 at 4 42 09 PM
sylvinite commented 4 years ago

Looks good. Since the value was merely aesthetic, no prior runs need to be re-done. Just make sure to deploy this after the routine samples for this week have been started.