Clinical-Genomics / microSALT

Microbial Sequence Analysis and Loci-based Typing pipeline for use on NGS WGS data.
GNU General Public License v3.0
2 stars 3 forks source link

Parameter file support #93

Closed sylvinite closed 4 years ago

sylvinite commented 4 years ago

Description

The features of this PR primarily concerns end-users/bioinformaticians/internals

This is a summary of the changes made.

Miniscule:

Primary function of PR

Testing

This is a description of the tests necessary to verify the stability of the PR. In order to verify the stability of the PR, the following must be tested:

_Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, MicrobialWGS.xlsx

Extended routine:

Test results

The values of MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx with one exception. The exception is that the provided json files have been scrubbed of Sample ID, thus incorrectly flagging NTC samples as failing.

Running a json file only containing info for MIC3109A2 successfully generated a Typing and QC report with correct results.

Modifying the inbound json in order to make it unusable consistently generated the error ERROR - Parameter XXX needs to be provided in sample json. Formatting example:

Sign-offs