Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI
MIT License
1 stars 0 forks source link

Revert Validate and add another endpoint to check the validation errors of a demo submission #123

Closed northwestwitch closed 5 months ago

northwestwitch commented 5 months ago

This PR adds | fixes:

How to test:

Expected outcome:

Review:

This version is a:

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.16%. Comparing base (ef00987) to head (ab870f7). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== + Coverage 95.02% 95.16% +0.14% ========================================== Files 11 11 Lines 462 476 +14 ========================================== + Hits 439 453 +14 Misses 23 23 ``` | [Flag](https://app.codecov.io/gh/Clinical-Genomics/preClinVar/pull/123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Clinical-Genomics/preClinVar/pull/123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics) | `95.16% <100.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

northwestwitch commented 5 months ago

Tested locally:

image