Fix requests in proxy endpoints and parsing of observedIn - Githubissues

Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI

MIT License

1 stars 0 forks source link

Fix requests in proxy endpoints and parsing of observedIn #17

Closed northwestwitch closed 2 years ago

northwestwitch commented 2 years ago

This PR adds | fixes:

Fixes parsing of csv files that was not capturing observedIn key/values (fix #16)
Added the proxy endpoint to submission validate (fix #12, fix #5)
Fixed proxy endpoint to submit the right request data

How to test:

GitHub actions test submission endpoints with no valid api key. Tests should pass
Manually test both proxy endpoints with a valid api key and the fixed sdemo ubmission object

Expected outcome:

Both endpoint should return success and a submission number (example SUB:XXXXXXX)

Review:

[x] Tests executed by GitHub actions, CR

This version is a:

[ ] MAJOR - when you make incompatible API changes
[x] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 2 years ago

Tested csv_2_json endpoint: 🆗

Tested validate endpoint 🆗