Do not crash when empty CSV files are provided - Githubissues

Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI

MIT License

1 stars 0 forks source link

Do not crash when empty CSV files are provided #43

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

This PR adds | fixes:

fix #42

How to test:

Deploy the branch on cg-vm1
Test the csv_2_json endpoint with an empty file

Expected outcome:

[ ] The endpoint should not crash, but return a 400 error with the message:Both 'Variant' and 'CaseData' csv files are required and should not be empty

Review:

[ ] Code approved by
[ ] Tests executed by
[ ] "Merge and deploy" approved by

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 1 year ago

Looks like the Docker GitHub action doesn't like how I named this branch. I'm going to close this PR and open it with another branch name