Simplify and fix CSV and TSV files parsing - Githubissues

Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI

MIT License

1 stars 0 forks source link

Simplify and fix CSV and TSV files parsing #52

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

This PR adds | fixes:

Fix an error in current main branch causing the files to be parsed wrongly

How to test: Use the swagger http://127.0.0.1:8000/docs#/default/csv_2_json_csv_2_json_post

Convert CSV files to json submission
Convert TSV files to json submission

Expected outcome:

[x] Both tests should pass

Review:

[x] Tests executed by CR

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 1 year ago

Test using TSV files: 🆗

Test using CSV files: 🆗