Fixed muliple pheno parsing - Githubissues

Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI

MIT License

1 stars 0 forks source link

Fixed muliple pheno parsing #70

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

This PR adds | fixes:

Fix #69

How to prepare for test:

[ ] ssh to ...
[ ] Install on stage: bash servers/resources/SERVER.scilifelab.se/update-[THIS_TOOL]-stage.sh [THIS-BRANCH-NAME]

How to test:

Try converting a Variant file containing more than one phenotype (OMIM or HPO)

Expected outcome:

[x] Json submission should contain multiple phenotypes, not just one as it is now

Review:

[x] Tests executed by CR
[ ] "Merge and deploy" approved by

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 1 year ago

Tested with same file as in #69

This branch: 🆗

Tested with a Variant file containing multiple OMIM IDs: 🆗