Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI
MIT License
1 stars 0 forks source link

ClinVar validation doesn't pass for uppercase/lowercase problem #77

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

Example:

{'message': 'Created json file contains validation errors: ["\'Likely Pathogenic\' is not one of [\'Pathogenic\', \'Likely pathogenic\', \'Uncertain significance\', \'Likely benign\', \'Benign\', \'Pathogenic, low penetrance\', \'Uncertain risk allele\', \'Likely pathogenic, low penetrance\', \'Established risk allele\', \'Likely risk allele\', \'affects\', \'association\', \'drug response\', \'confers sensitivity\', \'protective\', \'other\', \'not provided\']", "\'Likely Pathogenic\' is not one of [\'Pathogenic\', \'Likely pathogenic\', \'Uncertain significance\', \'Likely benign\', \'Benign\', \'Pathogenic, low penetrance\', \'Uncertain risk allele\', \'Likely pathogenic, low penetrance\', \'Established risk allele\', \'Likely risk allele\', \'affects\', \'association\', \'drug response\', \'confers sensitivity\', \'protective\', \'other\', \'not provided\']", \'[] is too short\']'}

I think I'll move this issue to PreClinVar and I'll make it ignore case

northwestwitch commented 1 year ago

This is fixed now:

image

The only problem left is missing phenotype in one or more variants (empty list, hence: []) - but this is not a bug