Clinical-Genomics / preClinVar

A ClinVar API submission helper written in FastAPI
MIT License
1 stars 0 forks source link

Combine `Reference sequence` and `HGVS` fields from Variant file to create the hgvs field in json submission object #83

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

This PR adds | fixes:

How to prepare for test:

How to test:

Expected outcome:

Review:

This version is a:

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.04% // Head: 95.12% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (2fdc434) compared to base (caea36b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #83 +/- ## ========================================== + Coverage 95.04% 95.12% +0.08% ========================================== Files 9 10 +1 Lines 424 431 +7 ========================================== + Hits 403 410 +7 Misses 21 21 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.12% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics) | Coverage Δ | | |---|---|---| | [preClinVar/demo/\_\_init\_\_.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9kZW1vL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [tests/test\_main.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-dGVzdHMvdGVzdF9tYWluLnB5) | `100.00% <ø> (ø)` | | | [preClinVar/\_\_version\_\_.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9fX3ZlcnNpb25fXy5weQ==) | `100.00% <100.00%> (ø)` | | | [preClinVar/constants.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9jb25zdGFudHMucHk=) | `100.00% <100.00%> (ø)` | | | [preClinVar/file\_parser.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-cHJlQ2xpblZhci9maWxlX3BhcnNlci5weQ==) | `91.77% <100.00%> (+0.05%)` | :arrow_up: | | [tests/test\_file\_parser.py](https://codecov.io/gh/Clinical-Genomics/preClinVar/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics#diff-dGVzdHMvdGVzdF9maWxlX3BhcnNlci5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Clinical-Genomics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

northwestwitch commented 1 year ago

Tested locally: 🆗

Content of Variant file:

image image
northwestwitch commented 1 year ago

Thanks @dnil I'll release and deploy the new version both on stage and prod. Remains to understand how to amend an existing submission from Scout now! 🤔