Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
151 stars 46 forks source link

LImit variant classif in ClinVar to ACMG terms if user selects ACMG assertion criteria #3715

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

I've received an email with feedback from a test submission using the API (I guess there is still manual inspection when they see that a submission, even if it's a test one, returns error).

Reason why the submission failed:

Additionally:

Honestly I just selected a random term in order to test the process, but this comment is useful. Perhaps we should start by limiting the available classification options in that select to what's available in the ACMG? That would be less of a headache for the users!

northwestwitch commented 1 year ago

While the submission failure error is already fixed (during the development of #3715 I wrongly used clinvarAccession instead submissionName ( I think the error was that, even if I didn't have a rs* name for it, but something like SUBxxx), I will introduce a fix for the ACMG problem:

I am considering removing the non-ACMG terms from the options, or even better limiting the available classification options to the ACMG ones if the assertion criteria are the ACMG guidelines.