Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
151 stars 46 forks source link

Where do the variants custom images appear in scout demo? #4085

Closed northwestwitch closed 1 year ago

northwestwitch commented 1 year ago

I'm still working on re-writing the scout load pydantic check in pydantic 2 and I don't understand this thing:

The images under the 'str' field at this line

That are saved in the case like this:

image

Where do they show up??

dnil commented 1 year ago

On the case page, near the chromograph images? I believe e.g. Lund uses these for mitochondrial plots, and perhaps some reviewer-like images on STRs.

dnil commented 1 year ago

Ah, right, the custom_images case go to the case page, but...

northwestwitch commented 1 year ago

Ah, right, the custom_images case go to the case page, but...

Right?

image
dnil commented 1 year ago

the strs go on the variant page:

dnil commented 1 year ago

https://github.com/Clinical-Genomics/scout/blob/f9b49d8cc39c0f036a62ffc87b2d54c3d388bd32/scout/server/blueprints/variant/templates/variant/variant.html#L171

dnil commented 1 year ago

I guess ‘variant’ would be a good substitute for ‘str’ here… 😸

northwestwitch commented 1 year ago

I guess ‘variant’ would be a good substitute for ‘str’ here… 😸

Already done! :)

northwestwitch commented 1 year ago

AHHHHHH, "str" is the variant category, check it out here:

https://github.com/Clinical-Genomics/scout/blob/f9b49d8cc39c0f036a62ffc87b2d54c3d388bd32/scout/adapter/mongo/case.py#L893

I should fix it before renaming it!