search

Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
152 stars 46 forks source link

Hide compounds, make compound_rank_score exclusive? #4105

Open dnil opened 1 year ago

dnil commented 1 year ago

Currently, the hide compounds rank score is used inclusively, so that e.g. if the user enters hide 10, variants up to and including 10 are hidden. This is intuitive on one level, but the user often operates with the level of last included rank score in mind, so having to think "I want to keep 10, so enter 9 there". Not huge, and everyone is different but lets at least have a quick discussion..

Screenshot 2023-10-02 at 12 37 30

northwestwitch commented 1 year ago

Perhaps modify the label "compound tank score" into "compound rank score >" ?

dnil commented 1 year ago

Absolutely, we should update the label if we change it - though I would prefer "compound rank score <", as the feature is to hide variants. And no tanks! 😸

northwestwitch commented 1 year ago

Then it has to be <= no?

dnil commented 1 year ago

Well, depending on if we agree to change it or not, and given that we have trouble discussing it, we should probably add a few more words in the tooltip to make sure it is clear. It does give feedback through what is hidden/dismiss-colored so it's not that it is super confusing, or that it can't be understood if one looks carefully. More that one can read it differently on quick use, and that one probably goes to the dialog with the lowest number to keep in mind rather than highest to hide.