search

Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
152 stars 46 forks source link

Add an Edit-function for authors of ACMG classifications in Scout #4208

Closed TJO-Lund closed 6 months ago

TJO-Lund commented 1 year ago

Can an Edit-function be added to the ACMG-classification-module in Scout, available to the author of each ACMG-classification? For example, when we have meetings about a variant, with the author of a classification presenting, we would like for the author to be able to edit the ACMG-classification without having to recreate it from scratch. I believe this would also save time for everybody involved in analysis as any minor error means they have to fill in the form "Evidence of pathogenicity" all over.

dnil commented 1 year ago

Same as with the regular comments perhaps, adding a short-ish time edit-window after save? Or skip that? Technically it doesn't matter, it's just that other users will perhaps base their judgement on the existing classifications, so adding a new reclassification has been the mode of operation. Both have merit. Being able to edit saves effort. Not being able to saves history. Both should be about equally safe.

TJO-Lund commented 1 year ago

Our group in Lund vote for the same solution for editing as for regular comments (and I do not see a need for a time-edit-window).

TJO-Lund commented 6 months ago

Hi, can I get an update on this issue? It is pretty annoying to have to redo the whole classification, including copying comments, when for example discussing a variant in a meeting.

northwestwitch commented 6 months ago

If I understand you correctly you'd like to have an "edit" button that clicked brings you to the classification form where you have preselected all the choices that led to the old classification? If that's the case I think it won't be possible to edit classifications retroactively because we don't store the choice criteria in the database.

We can change the code so that we start saving them to edit the new classifications

northwestwitch commented 6 months ago

If I understand you correctly you'd like to have an "edit" button that clicked brings you to the classification form where you have preselected all the choices that led to the old classification? If that's the case I think it won't be possible to edit classifications retroactively because we don't store the choice criteria in the database.

We can change the code so that we start saving them to edit the new classifications

Ah wait, I lied. I've found where the info is stored now. I'll start working on this feature!