Closed northwestwitch closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.62%. Comparing base (
4df9c81
) to head (29a2bf6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Ready for review.
Tests speed seems higher that this morning:
Check for instance tests from this PR
In part I feel that was due to some issue on GitHub; I think it was a couple of mins faster per test just a few days back? Anyway, the install order is surely better and parallelising a bit more seems all good!
In part I feel that was due to some issue on GitHub; I think it was a couple of mins faster per test just a few days back? Anyway, the install order is surely better and parallelising a bit more seems all good!
Yes, it was definitely slow this morning, but this should hopefully be faster. Here's the stats for another PR that I merged yesterday:
Another PR from a few days back, faster than the one above, but slower than this one:
This PR adds a functionality or fixes a bug. OR This PR marks a new Scout release. We apply semantic versioning. This is a major/minor/patch release for reasons.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: