Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
147 stars 43 forks source link

Attempt at speeding up tests #4650

Closed northwestwitch closed 1 month ago

northwestwitch commented 1 month ago

This PR adds a functionality or fixes a bug. OR This PR marks a new Scout release. We apply semantic versioning. This is a major/minor/patch release for reasons.

Testing on cg-vm1 server (Clinical Genomics Stockholm) **Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `ssh @cg-vm1.scilifelab.se` 1. `sudo -iu hiseq.clinical` 1. `ssh localhost` 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `podman ps` 1. Stop the service with current deployed branch: `systemctl --user stop scout.target` 1. Start the scout service with the branch to test: `systemctl --user start scout@` 1. Make sure the branch is deployed: `systemctl --user status scout.target` 1. After testing is done, repeat procedure at [https://pax.scilifelab.se/](https://pax.scilifelab.se), which will release the allocated resource (`scout-stage`) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm) **Prepare for testing** 1. `ssh @hasta.scilifelab.se` 1. Book your testing time using the Pax software. `us; paxa -u -s hasta -r scout-stage`. You can also use the WSGI Pax app available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `conda activate S_scout; pip freeze | grep scout-browser` 1. Deploy the branch to test: `bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b ` 1. Make sure the branch is deployed: `us; scout --version` 1. After testing is done, repeat the `paxa` procedure, which will release the allocated resource (`scout-stage`) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.

Review:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.62%. Comparing base (4df9c81) to head (29a2bf6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4650 +/- ## ======================================= Coverage 84.62% 84.62% ======================================= Files 309 309 Lines 18767 18767 ======================================= Hits 15882 15882 Misses 2885 2885 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

northwestwitch commented 1 month ago

Ready for review.

Tests speed seems higher that this morning:

Check for instance tests from this PR

image
dnil commented 1 month ago

Ready for review.

Tests speed seems higher that this morning:

Check for instance tests from this PR image

In part I feel that was due to some issue on GitHub; I think it was a couple of mins faster per test just a few days back? Anyway, the install order is surely better and parallelising a bit more seems all good!

northwestwitch commented 1 month ago

In part I feel that was due to some issue on GitHub; I think it was a couple of mins faster per test just a few days back? Anyway, the install order is surely better and parallelising a bit more seems all good!

Yes, it was definitely slow this morning, but this should hopefully be faster. Here's the stats for another PR that I merged yesterday:

image
northwestwitch commented 1 month ago

Another PR from a few days back, faster than the one above, but slower than this one:

image