Open dnil opened 4 weeks ago
Attention: Patch coverage is 80.78078%
with 64 lines
in your changes missing coverage. Please review.
Project coverage is 84.35%. Comparing base (
b8f21e7
) to head (02e4f6b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Im setting this ready for review now, and testing it on stage. Looks good on initial case load, but there are a couple of remaining issues with the IGV views.
Ok, so, the IGV issue is fixed and this is now fully open for review.
I am feeling ambiguous about the variant class part. The loading is good, and I really like having a separate collection. It was tempting to make a polymorphic variant obj, but that is a somewhat fundamental and hence error prone refactor.
I also decided to skip the omics_variant page for now. I feel the list view is what is really going to be used anyway.
Failed conditions
1 Security Hotspot
3.2% Duplication on New Code (required ≤ 3%)
This PR adds a functionality - drop outrider/fraser view.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: