Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
147 stars 43 forks source link

Parse drop #4654

Open dnil opened 4 weeks ago

dnil commented 4 weeks ago

This PR adds a functionality - drop outrider/fraser view.

Testing on cg-vm1 server (Clinical Genomics Stockholm) **Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `ssh @cg-vm1.scilifelab.se` 1. `sudo -iu hiseq.clinical` 1. `ssh localhost` 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `podman ps` 1. Stop the service with current deployed branch: `systemctl --user stop scout.target` 1. Start the scout service with the branch to test: `systemctl --user start scout@` 1. Make sure the branch is deployed: `systemctl --user status scout.target` 1. After testing is done, repeat procedure at [https://pax.scilifelab.se/](https://pax.scilifelab.se), which will release the allocated resource (`scout-stage`) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm) **Prepare for testing** 1. `ssh @hasta.scilifelab.se` 1. Book your testing time using the Pax software. `us; paxa -u -s hasta -r scout-stage`. You can also use the WSGI Pax app available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `conda activate S_scout; pip freeze | grep scout-browser` 1. Deploy the branch to test: `bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b ` 1. Make sure the branch is deployed: `us; scout --version` 1. After testing is done, repeat the `paxa` procedure, which will release the allocated resource (`scout-stage`) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.

Review:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 80.78078% with 64 lines in your changes missing coverage. Please review.

Project coverage is 84.35%. Comparing base (b8f21e7) to head (02e4f6b).

Files Patch % Lines
scout/server/blueprints/omics_variants/views.py 32.55% 29 Missing :warning:
scout/adapter/mongo/omics_variant.py 73.33% 16 Missing :warning:
...ut/server/blueprints/omics_variants/controllers.py 33.33% 14 Missing :warning:
scout/adapter/mongo/case.py 81.81% 2 Missing :warning:
scout/models/omics_variant.py 98.98% 1 Missing :warning:
...cout/server/blueprints/alignviewers/controllers.py 90.00% 1 Missing :warning:
scout/server/blueprints/alignviewers/views.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4654 +/- ## ========================================== - Coverage 84.42% 84.35% -0.08% ========================================== Files 311 318 +7 Lines 18756 19065 +309 ========================================== + Hits 15835 16082 +247 - Misses 2921 2983 +62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dnil commented 2 weeks ago

Screenshot 2024-06-17 at 10 41 41

dnil commented 5 days ago

Im setting this ready for review now, and testing it on stage. Looks good on initial case load, but there are a couple of remaining issues with the IGV views.

Screenshot 2024-06-26 at 16 52 05

dnil commented 3 days ago

Ok, so, the IGV issue is fixed and this is now fully open for review.

Screenshot 2024-06-28 at 09 31 36

I am feeling ambiguous about the variant class part. The loading is good, and I really like having a separate collection. It was tempting to make a polymorphic variant obj, but that is a somewhat fundamental and hence error prone refactor.

I also decided to skip the omics_variant page for now. I feel the list view is what is really going to be used anyway.

sonarcloud[bot] commented 3 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud