Closed northwestwitch closed 2 weeks ago
Nice! Just ping when ready for review!
Attention: Patch coverage is 78.57143%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 84.50%. Comparing base (
5e7adeb
) to head (2d59d03
).
Files | Patch % | Lines |
---|---|---|
scout/server/blueprints/variant/controllers.py | 60.00% | 2 Missing :warning: |
scout/server/extensions/loqus_extension.py | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok I got confused by the fact that loqusdb api returns 404 when a variant is not found (I was expecting 200 but {} as content) and also from scout that modifies the response from that api before parsing it 🙄
Now it should be always returning {}, regardless of if the variant is found or not. But should flash a message if there is a connection error
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test -- on cg-vm1:
How to test -- locally:
Expected outcome:
Review: