Closed dnil closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.41%. Comparing base (
027b5c0
) to head (41acc99
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This PR adds a functionality or fixes a bug.
Swapped filled chevrons/arrows to indicate "what is" in the menu state, rather than what "will be" when the icon is clicked. This behaviour is probably a bit more common, though both certainly have merit. Also added a separate card to make the hidden/folded matching vars stand out a bit more.
Semantically it clashes with the collapsible sidebar double chevron style as well. I decided to keep the current since it feels obvious when clicking it to me, but please shout if someone is nauseated by the logic conflict!
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: