Closed dnil closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.42%. Comparing base (
976bb25
) to head (f8c4c0d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Approving because it's working and we need a quick fix, but I'm not very fond of the solution. I think it's good for now but we should consider refactoring soon for simplifying so the code would be more readable and maintainable.
But as I said, it works so it's good for me! 👍🏻
I liked alphabetical better too. :) We could make two ordered dicts, one with categories and one with files. Or we could refactor to make it one call per file instead of the outer and inner thing. It probably doesn’t save much to do a few things only once per category. But not this week! 😸
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This PR adds a functionality or fixes a bug.
The load order was perturbed last week with 4.83 introducing sets of file type categories, to accommodate nf-core raredisease MT VCFs. Introducing an alpabetical sort will work around the problem encountered in #4682 in the sense that SNVs will be loaded before SVs, and in particular
cancer
beforecancer_sv
, and the collision resolution should be consistent.Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: