Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
147 stars 43 forks source link

Version 4.84 - fix load order, chanjo-report extension load warning, … #4687

Closed dnil closed 1 week ago

dnil commented 1 week ago

…loqus connection flash etc

This PR adds a functionality or fixes a bug.

[4.84]

Changed

Testing on cg-vm1 server (Clinical Genomics Stockholm) **Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `ssh @cg-vm1.scilifelab.se` 1. `sudo -iu hiseq.clinical` 1. `ssh localhost` 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `podman ps` 1. Stop the service with current deployed branch: `systemctl --user stop scout.target` 1. Start the scout service with the branch to test: `systemctl --user start scout@` 1. Make sure the branch is deployed: `systemctl --user status scout.target` 1. After testing is done, repeat procedure at [https://pax.scilifelab.se/](https://pax.scilifelab.se), which will release the allocated resource (`scout-stage`) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm) **Prepare for testing** 1. `ssh @hasta.scilifelab.se` 1. Book your testing time using the Pax software. `us; paxa -u -s hasta -r scout-stage`. You can also use the WSGI Pax app available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `conda activate S_scout; pip freeze | grep scout-browser` 1. Deploy the branch to test: `bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b ` 1. Make sure the branch is deployed: `us; scout --version` 1. After testing is done, repeat the `paxa` procedure, which will release the allocated resource (`scout-stage`) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.

Review:

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (c3483cc) to head (4e3fbc8).

Files Patch % Lines
scout/__version__.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4687 +/- ## ======================================= Coverage 84.42% 84.42% ======================================= Files 311 311 Lines 18756 18756 ======================================= Hits 15835 15835 Misses 2921 2921 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dnil commented 1 week ago

Clearer loqusdb flash: Screenshot 2024-06-24 at 12 58 02 No warning if chanjo is not configured:

Screenshot 2024-06-24 at 13 08 42

Matching collapse arrow causality swapped: Screenshot 2024-06-24 at 13 17 43

dnil commented 1 week ago

Tested the HGNC gene class change by reloading databases and clicking around for a bit, as per the original PR. Updates were successful:

Screenshot 2024-06-24 at 14 05 59 Screenshot 2024-06-24 at 14 14 23 Screenshot 2024-06-24 at 14 18 56 Screenshot 2024-06-24 at 14 18 00
dnil commented 1 week ago

✅ Deployed to hasta prod:

Screenshot 2024-06-24 at 14 49 17 Screenshot 2024-06-24 at 14 49 32

✅ Updating dbs:

Screenshot 2024-06-24 at 14 53 00 Screenshot 2024-06-24 at 14 55 04 Screenshot 2024-06-24 at 14 56 18 Screenshot 2024-06-24 at 15 00 00

✅ Deployed to cg-services-prod:

Screenshot 2024-06-24 at 15 02 15