Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
149 stars 46 forks source link

Add CoLoRSdb and gnomAD keys #4742

Closed fellen31 closed 2 months ago

fellen31 commented 2 months ago

Would it be a good idea to add allele frequencies from Consortium of Long Read Sequencing Database (CoLoRSdb), preferably as colorsdb_af?

Could I also get gnomad_af and gnomad_popmax_af added as gnomAD keys? 😃

dnil commented 2 months ago

Yes, let's add CoLoRSdb. Is the lower case string its standard key?

And what's with the gnomAD lower case INFO keys? 😆 Is this from a new VEP version, or are you freestyling a little? Could we expect to see them from other pipes as well?

dnil commented 2 months ago

Don't get me wrong, it does make sense; I'm pretty annoyed with things like gnomADg_AF_POPMAX, not to mention happy not to have to add a case sensitive CoLoRSdb. 😄

fellen31 commented 2 months ago

The lowercase gnomAD keys come from using echtvar instead of VEP to add the frequencies. They supply a pre-encoded gnomad database at a handy size (~7 GB), where the keys are encoded as lowercase.

The CoLoRSdb VCF key is AF so I set it to colorsdb_af.

dnil commented 2 months ago

Supporting Brents stuff out of the box sounds nice, and following the pattern for CoLoRSdb seems like a plan. It will be the first set of AFs that don't end in capital AF. 😆

dnil commented 2 months ago

Do we have example files somewhere?

fellen31 commented 2 months ago

Do we have example files somewhere?

/home/proj/development/rare-disease/felix/scout_test/filtered.vcf.gz

This one has gnomad_popmax_af and colorsdb_af but no gnomad_af. If you want to have all I can update it.

northwestwitch commented 2 months ago

This one has gnomad_popmax_af and colorsdb_af but no gnomad_af. If you want to have all I can update it.

Hi @fellen31 I'm working on this issue now. Would be nice to have an example with all 3, also super small would be fine, so I can copy one variant from it to include in the automatic tests of scout. But we can also add the test for gnomad_af later, so no rush!

fellen31 commented 2 months ago

Hi, I've updated the same file to include all three!

northwestwitch commented 2 months ago

Hi, I've updated the same file to include all three!

Nice, thanks!