Closed dnil closed 2 months ago
Attention: Patch coverage is 85.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 84.20%. Comparing base (
a4f46b7
) to head (175f5ea
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
scout/models/omics_variant.py | 84.21% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some float values in fraser and outrider tsvs can apparently be empty str as well. Adding a conversion kindly provided from https://github.com/pydantic/pydantic/discussions/2687 to fix that!
I've run a
scout setup demo
and noticed these fields:
- [ ] Could we rename the geneID to ensembl_gene or something similar
- [ ] sampleID to sample_id
- [ ] meanCorrected to mean_corrected
- [ ] normcounts to norm_counts
- [ ] rawcounts to raw_counts
Nope, should have been done on https://github.com/Clinical-Genomics/scout/pull/4654. 😉 Jk, good call and in time before this went full production. Do we need to support some migration, or should we just mention that these will not work for cases already loaded? The so far only really used one is sampleID
which is critical for individual matching, but is only used at load time so we can safely migrate it.
The so far only really used one is
sampleID
which is critical for individual matching, but is only used at load time so we can safely migrate it.
Sorry I've just noticed. But since we are not in full production perhaps we can manually modify sample ids of the cases already loaded.. Shouldn't be so many
The so far only really used one is
sampleID
which is critical for individual matching, but is only used at load time so we can safely migrate it.Sorry I've just noticed. But since we are not in full production perhaps we can manually modify sample ids of the cases already loaded.. Shouldn't be so many
Yes, I think it’s very well timed here - only test cases yet afaik. And it’s so new I doubt many others have implemented yet, but…
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This PR adds a functionality or fixes a bug.
Fix #4800 - rename DROP TSV columns according to current Tomte status
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: