Closed northwestwitch closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.21%. Comparing base (
80df00a
) to head (e44c44b
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This should fix the issue at hand. Are there other downstream problems from the same issue to consider? I noted a few other direct
geneish["ensembl_id"]
uses, but have not looked carefully at them!
I'll check if they are an issue
I found just another situation in the code which might pose a risk --> https://github.com/Clinical-Genomics/scout/blob/80df00ac3e1dd93d462cfecca697aeea1dc7661f/scout/build/variant/gene.py#L57
Fixed in this PR!
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This PR adds a functionality or fixes a bug.
After the fix:
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: