Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
152 stars 46 forks source link

design principles, extensions #4810

Closed parlar closed 2 months ago

parlar commented 2 months ago

Regarding topic https://github.com/Clinical-Genomics/scout/issues/4798 I have a design question. We would rather avoid implementing a separate flask app for our third-party integration / export tool, but a view will be required.

Would you prefer encapsulating all functionality needed by the tool in the extension such that it also includes blueprints and views?

Like that:

export_extension/
│
├── __init__.py
├── views.py
├── blueprints.py
└── templates/
    └── export_extension/
        └── export.html

This is probably a silly question. I have zero experience of flask development and don't know how things are usually done.

dnil commented 2 months ago

In practice that would work, but the way we have been approaching it is to have extension view support integrated in the regular view server/blueprints hierarchy and calling on the extension code as needed to communicate with the external service api.

parlar commented 2 months ago

super!

parlar commented 2 months ago

bye

northwestwitch commented 2 months ago

bye

bye! 😄