refactor app logging - Githubissues

northwestwitch commented 2 weeks ago

This PR adds a functionality or fixes a bug.

Fix #4849

Testing on cg-vm1 server (Clinical Genomics Stockholm)

**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `ssh @cg-vm1.scilifelab.se` 1. `sudo -iu hiseq.clinical` 1. `ssh localhost` 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `podman ps` 1. Stop the service with current deployed branch: `systemctl --user stop scout.target` 1. Start the scout service with the branch to test: `systemctl --user start scout@` 1. Make sure the branch is deployed: `systemctl --user status scout.target` 1. After testing is done, repeat procedure at [https://pax.scilifelab.se/](https://pax.scilifelab.se), which will release the allocated resource (`scout-stage`) to be used for testing by other users.

Testing on hasta server (Clinical Genomics Stockholm)

**Prepare for testing** 1. `ssh @hasta.scilifelab.se` 1. Book your testing time using the Pax software. `us; paxa -u -s hasta -r scout-stage`. You can also use the WSGI Pax app available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). 1. (optional) Find out which scout branch is currently deployed on cg-vm1: `conda activate S_scout; pip freeze | grep scout-browser` 1. Deploy the branch to test: `bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b ` 1. Make sure the branch is deployed: `us; scout --version` 1. After testing is done, repeat the `paxa` procedure, which will release the allocated resource (`scout-stage`) to be used for testing by other users.

How to test:

Deploy this branch on stage https://github.com/Clinical-Genomics/servers/pull/1448/files
Deploy on stage
Check the logs created under /tmp/tmp_scout_users_activity.log
Check also the logs of the container: podman logs

Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.

Review:

[x] code approved by DN
[x] tests executed by CR

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (44aaa30) to head (02d0357). Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
scout/log/log.py	61.11%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4857 +/- ## ========================================== + Coverage 84.62% 84.78% +0.16% ========================================== Files 319 319 Lines 19315 19289 -26 ========================================== + Hits 16345 16354 +9 + Misses 2970 2935 -35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.