Closed dnil closed 1 month ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.77%. Comparing base (
c73ea6b
) to head (1803a48
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
❌ Before: ✅ After:
Ping @mathiasbio - its on stage now, enabled for all cancer
track cases as well. Is that as intended?
Sorry for the late reply! Looks like it's working 🙏 Thank you! I don't know how this implementation works, if it will display the button even if GENS results are not uploaded. But either way it should be fine. We're planning to make this release SOON! (I keep saying this but it is true) and if the button is showing and not leading anywhere in the interim time it should be fine!
Good, and quite agree. It will be nice when they are loaded, but reaching a "missing gens data" page in the meantime is no biggie.
There is an old issue on gens to allow api polling for case data. Feel free to work on/nudge that one if you would wish to have the buttons more adaptive.
This PR adds a functionality or fixes a bug.
Gens button enabled also on cancer individuals table (if gens integration is enabled).
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: