search

Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
151 stars 46 forks source link

BA is currently not quite stand alone... #4921

Closed dnil closed 1 week ago

dnil commented 2 weeks ago

Describe the bug When adding ACMG BA, I expect to see the ACMG prediction be Benign.

To Reproduce Steps to reproduce the behavior:

  1. Go to ACMG classify
  2. Click on BA1
  3. Fill in some other benign criteria that will have an impact, but less so, eg a BS and a BP
  4. See error (classification changes to Likely Benign) Screenshot 2024-10-09 at 16 20 47
northwestwitch commented 1 week ago

If you haven't I can start with this @dnil

dnil commented 1 week ago

Ah, did you start already? I've been mangling those pages for a bit now so it would feel natural to just do it otherwise. I didn't assign since I was unsure how much time I would have, but it looks decent right now.

northwestwitch commented 1 week ago

Ah, did you start already? I've been mangling those pages for a bit now so it would feel natural to just do it otherwise. I didn't assign since I was unsure how much time I would have, but it looks decent right now.

No, I haven't started. It's all yours! :)