Closed northwestwitch closed 5 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.78%. Comparing base (
218cbe6
) to head (d5457ea
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
It gets a little tedious with the redundant PASS and FAIL ones, so checking against that would be an improvement.
You want me to add this check in the PR or it is fine as it is for now? Pehaps we could get some users' feedback afterwards
It gets a little tedious with the redundant PASS and FAIL ones, so checking against that would be an improvement.
You want me to add this check in the PR or it is fine as it is for now? Pehaps we could get some users' feedback afterwards
I think it is tentatively better than main already, so good to merge if you like. If it looks easy and safe to do the check, I'd say do it now while we are thinking about it. But if it gets complicated its fine to leave the extra badges there for a bit.
I think it is tentatively better than main already, so good to merge if you like. If it looks easy and safe to do the check, I'd say do it now while we are thinking about it. But if it gets complicated its fine to leave the extra badges there for a bit.
I'll just merge then. If somebody complains we can fix it
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
**Prepare for testing** 1. Make sure the PR is pushed and available on [Docker Hub](https://hub.docker.com/repository/docker/clinicalgenomics/scout-server-stage) 1. Fist book your testing time using the Pax software available at [https://pax.scilifelab.se/](https://pax.scilifelab.se). The resource you are going to call dibs on is `scout-stage` and the server is `cg-vm1`. 1. `sshTesting on hasta server (Clinical Genomics Stockholm)
**Prepare for testing** 1. `sshHow to test:
Expected outcome: The functionality should be working Take a screenshot and attach or copy/paste the output.
Review: