Clinical-Genomics / scout

VCF visualization interface
https://clinical-genomics.github.io/scout
BSD 3-Clause "New" or "Revised" License
148 stars 45 forks source link

Clinical filter - own gene panel -- not the other way around #594

Closed KickiLagerstedt closed 4 years ago

KickiLagerstedt commented 7 years ago

We have an issue regarding filtering using "clinical filter" and an "home made" gene panel (HGNC Symbols (case sensitive) filter):

What we do now: 1) filter with "clinical filter" 2) add home made gene filter 3) see variants

What we would like to do: 1) add home made gene filter 2) see all variants regarding these genes

bild

3) add clinical filter -

bild

Then we have to add the add home made gene filter again and press "filter variants"

bild

This is an risk if the added gene list is long - could be analyzing genes not been asked for so we would appreciate if this "bug" could be fixed.

// Kicki & Anna

dnil commented 7 years ago

Good discussion point! I guess the current logic is that when you press clinical filter, you should get the pre-defined clinical gene list?

KickiLagerstedt commented 7 years ago

Maybe... BUT if you use the HPO generated gene list it works the way we would like...

moonso commented 5 years ago

Could you have a look at this when you have time @dnil ?

dnil commented 4 years ago

Hm, I guess we could add an additional type of panel, e.g. a custom gene list panel, that the user could populate directly from the case page. Then use it much like we use the current "Dynamic gene panel" for HPO lists.

The only objection I can think of is that some genes may not be on the master panel etc, but that is exactly analogous for the HPO list. Anything I'm missing?

KickiLagerstedt commented 4 years ago

Låter bra! Tror inte att ngt är glömt…