Give unique key to samples

Clinical-Genomics / statina-ui

Frontend app for Statina

0 stars 0 forks source link

Give unique key to samples #145

Closed elevu closed 2 years ago

elevu commented 2 years ago

Description

Same sample ID was breaking the table, added a unique id

Issue number Closes

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit ec2b54b):

https://statina-stage--pr145-agne-issues4-8urowp8a.web.app

_{(expires Thu, 03 Feb 2022 09:57:05 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

Mropat commented 2 years ago

Is this an issue because we currently have duplicate sample ID in the database? We were meaning to clean those up, and enforce enique key index. Would that solve the problem without this PR?

elevu commented 2 years ago

yes it is, React needs unique Ids to render stuff properly, when do you plan to do that?

elevu commented 2 years ago

well, will merge for now