Clinical-Genomics / statina

2 stars 3 forks source link

Presentation of sample names in Zscore 13/18/21 graphs - medium priorty #190

Closed alieden closed 2 years ago

alieden commented 2 years ago

The sample names of the current batch is shown in different ways in the graphs (13/18/21), presumably to show different options.

We prefer the option shown in the Zscore 18 graph with vertical sample names so that you don't have to change the zoom level during analyis. Preferably the zoom level should be kept at 100% all the time. We typically use 24 or 26 inch screens (1920x1200 or 2560x1440) if that helps.

elevu commented 2 years ago

We are using the same graph component for the Zscore graphs with vertical sample names Jan-24-2022 14-02-23

Would you mind taking a screenshot of what is it that you would like to be displayed differently?

alieden commented 2 years ago

Odd. Now (the latest batch) all graphs (Zscore13/18/21) are shown diagonally instead in chrome? This means that you have to zoom 67% to be able to show the whole batch.

Better if the sample names could be shown vertically.

@.***

Från: Eleonora @.> Skickat: den 24 januari 2022 14:06 Till: Clinical-Genomics/statina @.> Kopia: Agne Liedén @.>; Author @.> Ämne: Re: [Clinical-Genomics/statina] Presentation of sample names in Zscore 13/18/21 graphs - medium priorty (Issue #190)

We are using the same graph component for the Zscore graphs with vertical sample names [Jan-24-2022 14-02-23]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F6919697%2F150787663-2bb5f41f-71d9-4676-9f76-834206d887eb.gif&data=04%7C01%7Cagne.lieden%40ki.se%7Cf041d959d1cf4d62c21e08d9df3a4844%7Cbff7eef1cf4b4f32be3da1dda043c05d%7C0%7C0%7C637786263679933043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xfb9vg1gvvXa%2F%2Bh8PgoH8m%2FkFIVL%2Fh93Apq3%2Fm%2BhmC0%3D&reserved=0

Would you mind taking a screenshot of what is it that you would like to be displayed differently?

- Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClinical-Genomics%2Fstatina%2Fissues%2F190%23issuecomment-1020079679&data=04%7C01%7Cagne.lieden%40ki.se%7Cf041d959d1cf4d62c21e08d9df3a4844%7Cbff7eef1cf4b4f32be3da1dda043c05d%7C0%7C0%7C637786263679933043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rHSFvU1Gd29KaX%2BvsRUzXlgCfyLsO52Or8t2ZCMPvq4%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFNPY7CQRDWYP7PZTNZVS2DUXVFDZANCNFSM5MPECSYA&data=04%7C01%7Cagne.lieden%40ki.se%7Cf041d959d1cf4d62c21e08d9df3a4844%7Cbff7eef1cf4b4f32be3da1dda043c05d%7C0%7C0%7C637786263679933043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8Vj%2FxIJ%2FbdoB57qjsjyJapttByKN%2FLK9BSxhCYMEvlo%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cagne.lieden%40ki.se%7Cf041d959d1cf4d62c21e08d9df3a4844%7Cbff7eef1cf4b4f32be3da1dda043c05d%7C0%7C0%7C637786263679933043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YmCVkUNBQf3VO%2BK05RT77XN7%2FzQZmMIvWzxrjbvVEw4%3D&reserved=0 or Androidhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cagne.lieden%40ki.se%7Cf041d959d1cf4d62c21e08d9df3a4844%7Cbff7eef1cf4b4f32be3da1dda043c05d%7C0%7C0%7C637786263679933043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oI0shOLWU4MizKxSTC2I3afvu5MDpdRcJ7F%2BqK62Sfg%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

När du skickar e-post till Karolinska Institutet (KI) innebär detta att KI kommer att behandla dina personuppgifter. Här finns information om hur KI behandlar personuppgifterhttps://ki.se/medarbetare/integritetsskyddspolicy.

Sending email to Karolinska Institutet (KI) will result in KI processing your personal data. You can read more about KI's processing of personal data herehttps://ki.se/en/staff/data-protection-policy.

elevu commented 2 years ago

would you mind taking a screenshot of the whole page where you see this problem?

alieden commented 2 years ago

sent it to your email (eleonora.maccacaro@scilifelab.se).

elevu commented 2 years ago

thank you!

alieden commented 2 years ago

Please also remove the label "0" shown below the axis for the legacy data.

alieden commented 2 years ago

Please add Y-axis labels also