Do not filter out other balsamic cases - Githubissues

Clinical-Genomics / trailblazer

Keep track of and manage analyses

MIT License

5 stars 2 forks source link

Do not filter out other balsamic cases #403

Closed islean closed 4 months ago

islean commented 4 months ago

Description

A fix applied in #394 has unfortunately been reverted. This re-reverts it and fixes the filter again. Closes https://github.com/Clinical-Genomics/cigrid-ui/issues/507.

Fixed

Filtering on balsamic does not filter out balsamic-qc etc.

How to prepare for test

[ ] ssh to hasta (depending on type of change)
[ ] activate stage: us
[ ] request trailblazer-stage on hasta: paxa

[ ] install on stage:

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b [THIS-BRANCH-NAME] -a

[ ] ssh to clinical-db (depending on type of change)
[ ] install on stage: bash /home/proj/production/servers/resources/clinical-db.scilifelab.se/update-trailblazer-ui-stage.sh [THIS-BRANCH-NAME]

How to test

[ ] login to ...
[ ] do ...

Expected test outcome

[ ] check that ...
[ ] Take a screenshot and attach or copy/paste the output.

Review

[ ] tests executed by
[ ] "Merge and deploy" approved by Thanks for filling in who performed the code review and the test!

This version is a

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

islean commented 4 months ago

Can we perhaps add a test that catches this behaviour if it goes wrong?

good idea! Added one now!

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

islean commented 4 months ago

Tested in stage:

islean commented 4 months ago

Deployed to production