Clinical-Genomics / trailblazer

Keep track of and manage analyses
MIT License
5 stars 2 forks source link

Patch parsing job ids #431

Closed seallard closed 2 months ago

seallard commented 2 months ago

Description

Introduced a bug in the previous refactoring of the scan command https://github.com/Clinical-Genomics/trailblazer/pull/423 when parsing and passing the parsed job ids.

Discovered it when I deployed to production today.

Fixed

This version is a

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

seallard commented 2 months ago

Tested in stage with actual job ids being parsed 😅

[hiseq.clinical@hasta:analysis] [S_base] $ trailblazer scan
Failed to update jobs grandaphid - 253757: [Errno 2] No such file or directory: '/home/proj/production/cancer/cases/grandaphid/analysis/slurm_jobids.yaml'
Updated status grandaphid - 253757: running 
Failed to update jobs goodbengal - 253945: [Errno 2] No such file or directory: '/home/proj/production/nipt/cases/goodbengal/output/sacct/submitted_jobs.yaml'
Updated status goodbengal - 253945: running 
Failed to update jobs helpedlab - 253964: [Errno 2] No such file or directory: '/home/proj/production/nipt/cases/helpedlab/output/sacct/submitted_jobs.yaml'
Updated status helpedlab - 253964: error 
Updated status immuneurchin - 292924: running 
Updated status crucialshiner - 292925: running 
Updated status currentlioness - 292926: running 
Updated status usablehoneybee - 292927: running 
Updated status assuredhaddock - 292934: running 
Updated status inspiredmongrel - 292938: running 
Updated status singulargoshawk - 292940: running 
Updated status intimategoldfish - 292941: running 
Updated status bigoctopus - 292950: running 
Updated status vitalcrayfish - 292952: running 
Updated status relevantgoblin - 292953: running 
Updated status classicredbird - 292963: running 
Updated status sinceretomcat - 292965: running 
Updated status expertmudfish - 292966: running 
Updated status proinsect - 292968: running 
Updated status handyearwig - 292970: running 
Updated status intimatefilly - 292971: running 
Updated status desiredhippo - 292972: running 
Updated status guidedstarfish - 292973: running 
Updated status genuineairedale - 292975: running 
Updated status trustedman - 292977: running 
Updated status perfectman - 292978: running 
Updated status gratefulduck - 292980: running 
Updated status hopefulchimp - 292982: running 
Updated status discretemoray - 292984: running 
Updated status crucialmidge - 292985: running 
Updated status rareboa - 292986: running 
Updated status certainunicorn - 292987: running 
Updated status genuinelionfish - 292989: running 
Updated status drivinghalibut - 292993: running 
Updated status dynamicelf - 292995: running 
All analyses updated!
seallard commented 2 months ago

Deployed to prod