Add endpoint error handling - Githubissues

Clinical-Genomics / trailblazer

Keep track of and manage analyses

MIT License

6 stars 2 forks source link

Add endpoint error handling #474

Closed seallard closed 3 months ago

seallard commented 3 months ago

This PR removes a lot of duplicated error handling logic in the endpoints by extracting it to a separate error handler.

The code is easier to read since the indentation is decreased, duplicated logic is removed, fewer overall lines of code and improved separation of concerns 👍

Additionally, it:

Ensures we do not return stack traces in the error response (security risk) but just log them instead.
Ensures the correct HTTP status is returned for internal server errors (should not be 409 for a blank catch-all exception).

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud