ClintonYounge / JS-Capstone-Group-Project

Restaraunt Meal (JS Capstone Group Project) is a JavaScript capstone project about building a web application based on an external API. We selected the Meals API that provides data about meals we like and then built the webapp around it.
https://clintonyounge.github.io/JS-Capstone-Group-Project/dist/
MIT License
2 stars 2 forks source link

Project To Be Reviewed #21

Open ClintonYounge opened 1 year ago

ClintonYounge commented 1 year ago

https://github.com/ClintonYounge/JS-Capstone-Group-Project/projects/1

Hello Reviewer. There are 3 Micronauts in this team.

levy002 commented 1 year ago

Hello @Team , :wave:

I'm Levy, your PR reviewer

Good job so far :+1: There are some issues that you still need to work on to go to the next project but you are almost there!

Status: REQUIRED CHANGES ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @levy002 in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ali-0111 commented 1 year ago

Hi, team I assigned tasks for the first day. Rest of them will be assigned on next days.

https://github.com/ClintonYounge/JS-Capstone-Group-Project/projects/1

jasonfelice commented 1 year ago

Hi @ClintonYounge,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

## Required Changes ♻️ - Also mentioned by the previous reviewer. Please make sure you have all the tasks assigned to the respective person in your Kanban board. ## Optional suggestions _Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better._ Cheers and Happy coding!πŸ‘πŸ‘πŸ‘ Please, remember to tag me in your question so I can receive the notification. ------ _As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s)._
sameedmohsin28 commented 1 year ago

Hi, The changes have been made as requested by both reviewers.

AlphaNtihinduka commented 1 year ago

STATUS: APPROVED :green_circle: :clap:

Hello TeamπŸ™‹β€β™‚οΈ,

Your project is complete! There is nothing else to say other than... Great job πŸ‘

approved-accepted

Congratulations! πŸŽ‰ TO HIGHLIGHT:

Now you can merge this branch and move on :1st_place_medal:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

HAPPY CODING AND GOOD LUCK WITH THE COMING ONES :crossed_fingers: :four_leaf_clover: