PDF Journal Fade at Bottom

[Neurochimp]

Hi,

I noticed that with your module enabledthe PDF page has a bit of a fade into the bottom of the journal that works fine for text journals but not for pdf as the page doesn't fully load in.

Is there a way to disable this? I noticed it seems to happen with the SWADE Rifts journals but not the core SWADE journals unless this module is enabled.

If that isn't possible, learning how to move the title of the journal over from on top to the left like you have would be great. It all comes back to the PDF. If I can get that title moved and the fade into bottom mechanic gone, I'd have more space for the page.

Thank you!

[saif-ellafi]

Hi, wanted to up this issue, it is also problematic for me

I believe something in Foundry caused this, because from PDF Pager module, the author has undone a previous change:

https://github.com/farling42/fvtt-pdf-pager/commit/a77b04fc58463b712ca24c4ed73671e0e43887f5

which originally was added here

https://github.com/farling42/fvtt-pdf-pager/commit/821f50a2562a08d77616f7d107a94ad5e2180bf1

.sheet.journal-entry .journal-entry-page.pdf {
    height: 100%;
}

.journal-entry-page.pdf iframe {
    min-height: unset;
    flex-basis: unset;
}

[saif-ellafi]

Anyways @ClipplerBlood - the CSS snippet above will fix this in journal-improvements.css Will submit a patch, althogh it seems that Farlon in PDF Pager removed it since now Foundry 10.290+ fixes this out of the box. But I could investigate why it doesn't impact this module.

[saif-ellafi]

Submitted PR https://github.com/ClipplerBlood/journal-improvements/pull/12