search

Clipy / KeyHolder

Record shortcuts in macOS, like Alfred.app.
https://clipy-app.com
MIT License
392 stars 33 forks source link

Add support for dark mode in 10. 14 Mojave #26

Closed mamiksik closed 4 years ago

mamiksik commented 5 years ago

Before: Dark mode off:

screenshot 2019-01-06 at 14 28 36

Dark mode on:

screenshot 2019-01-06 at 14 33 57

With this change: Dark mode off:

screenshot 2019-01-06 at 14 28 36

Dark mode on:

screenshot 2019-01-06 at 14 28 18
DivineDominion commented 5 years ago

Love the change! I noticed the active key combo color and the border of the example wouldn't look that nice on Mojave, though. Could you update the colors there, too?

When inactive, only the border looks weird

Screenshot 2019-04-03 at 11 09 02 Screenshot 2019-04-03 at 11 09 13

When active, the key combo color is oddly bright

Screenshot 2019-04-03 at 11 10 06 Screenshot 2019-04-03 at 11 10 10

Also I included a text field for border color reference.

rkbhochalya commented 5 years ago

@mamiksik @DivineDominion It looks like following after setting tintColor to .controlAccentColor, backgroundColor to .controlBackgroundColor and borderColor to .controlShadowColor in macOS v10.14.4

image image

DivineDominion commented 5 years ago

@Econa77 Since you're apparently reviewing PRs: I'm using this in a production app with great success already.

mamiksik commented 5 years ago

Hi, I totally forgot about this PR as I pushed it just before my finals :D @rkbhochalya If it is still relevant, I can make suggested changes and update the PR.

rkbhochalya commented 5 years ago

@mamiksik it should be, at least in Mojave. Not sure about API changes in upcoming update (macOS Catalina).

BTW I ended up using shpakovski/MASShortcut in my macOS grayscale mode app.