search

CloakProject / CloakCoin

Cloak is the fastest, most secure way to transact cryptocurrency using blockchain technology and truly next-gen ENIGMA encryption to create fully private transactions.
https://www.cloakcoin.com
MIT License
36 stars 34 forks source link

remove binaries #5

Closed tpoonach closed 6 years ago

tpoonach commented 6 years ago

Hi guys, I would like to contribute to this project. I am new and obviously don't know much, one thing is for sure, checking in binaries to a source repo is not a good idea for cross platform builds and for security, lets remove them mike

fradow-cloak commented 6 years ago

Hello,

First, I'd like to apologize on behalf of the Cloak team for the late response, and welcome you in the community.

We are used to communicate through Rocketchat. Don't hesitate to drop us a line and see what needs work.

As for your pull request, unfortunately, it cannot be merged. As you can see in the clockcoin.pro file, part of the Windows build process directly reference those file. While we are aware this is a bad practice, the first step is to get a Windows build running without them.

I'm actively working on this (along with having a better readme and and detailed steps to make the wallet on all platforms), you can see my progress here: https://github.com/fradow-cloak/CloakCoin/tree/improve-build-readme