search

Clojure-Intro-Course / babel

MIT License
2 stars 0 forks source link

[Le #134] Move the failing 'let' tests into a separate file and exclude from automatic running #47

Open stanislowskij opened 2 months ago

stanislowskij commented 2 months ago

⚠️ Imported from legacy repository. This issue is a duplicate of https://github.com/Clojure-Intro-Course/babel-legacy/issues/134.

There are tests that fail because of imprecise 'let' spec:

failure in (fn_defn_test.clj:217) : babel.fn-defn-test
(expect
 (t/make-pattern
  "Syntax problems with (fn [[x] {:a 5}] [[y] 7]):\nFails let spec; might be fixed in spec2.")
 (log/babel-test-message "(fn [[x] {:a 5}] [[y] 7])"))

           regex #"(?s)\QSyntax problems with (fn [[x] {:a 5}] [[y] 7]):
Fails let spec; might be fixed in spec2.\E(.*)" not found in "Syntax problems with (let [[x] {:a 5}] [[y] 7]):\nIn place of {:a 5} the following are allowed: a name or a vector\nIn place of :a the following are allowed: a name or a vector or a hashmap\nIn place of 5 the following are allowed: a vector\n\nIn Clojure interactive session on line 1 at position 29.\nCall sequence:\n[Clojure interactive session (repl)]"

Need to move them into a separate file and/or exclude from testing - they make it difficult to read the actual errors.

stanislowskij commented 2 months ago

These are currently commented out. Ideally we want a better way of handling these instead. Possibly some sort of flag for whether or not we are running them.