search

ClojureBridge / drawing

Experimental capstone app for ClojureBridge curriculum using Quil
25 stars 36 forks source link

Whitespace formatting changes. #15

Closed mookerji closed 9 years ago

mookerji commented 9 years ago

Some of the curriculum text is difficult to edit, as is, so I've added line wrapping in the curricular documents, changed some capitalization, and inserted white space into the project.clj.

seancorfield commented 9 years ago

With all the line formatting changes, it's really hard to see what the actual changes are in this PR and the "Additions" commit also seems to be just whitespace formatting.

Can you summarize what's actually changed here?

davidchambers commented 9 years ago

Could you remove the formatting commit? (git reset --hard 2a7e85a && git push origin additions --force should do the trick.) Once this pull request has been merged you could open a separate pull request for the formatting changes.

mookerji commented 9 years ago

Ack, sorry. I intended to follow up with clarification from the obscure title. Adding now.

seancorfield commented 9 years ago

I went through and reviewed the changes and as far as I can tell, the only actual changes - beyond formatting - seem to Capitalization of headings. If that's correct, I'll :+1: this. @mookerji can you confirm that really is the extent of the changes?

mookerji commented 9 years ago

I'm going to squash and doublecheck. One second.

mookerji commented 9 years ago

Yes, I can confirm that those are the only formatting changes. Thanks for reviewing it!

mookerji commented 9 years ago

Hey, can we merge this? @seancorfield @davidchambers Thanks!

davidchambers commented 9 years ago

I don't have permission to merge pull requests in this repository.