Clon1998 / mobileraker

A Flutter mobile app for Klipper/Moonraker
Other
488 stars 55 forks source link

Not saving printer setting when webcams configured in moonraker #292

Closed jelleh closed 11 months ago

jelleh commented 11 months ago

Bug Report

Description

Printer settings will not save when there are webcams configured in moonraker

Steps to Reproduce

  1. Go to 'hamburger menu'
  2. Click on 'settings'
  3. Change printer displayname
  4. Click the save icon
  5. See the error in debug log.
  6. printer displayname is not changes/saved

Error 400: Cannot overwrite webcam 'camera_top' sourced from Moonraker

Expected Behavior

When you have configured webcams in moonraker, you can not save printer settings. When i remove the webcam from moonraker, i can save the settings. I like to see that this works without removing my webcams in moonraker

Screenshots

In debug log: Error 400: Cannot overwrite webcam 'camera_top' sourced from Moonraker

Version Information

Debug Logs

In debug log after clicking save when configured [webcam camera_top] in moonraker Error 400: Cannot overwrite webcam 'camera_top' sourced from Moonraker

Additional Context

None


Checklist

To help us diagnose the issue, please ensure you've completed the following steps:

Clon1998 commented 11 months ago

Hey, Thanks for reporting this issue. Just to confirm, you are talking about webcams that are directly configured via a config file/section in moornaker?

jelleh commented 11 months ago

Yes that is correct, in my case it is in the file /home/pi/printer_data/config/moonraker.conf

[webcam camera_side] location: printer enabled: True service: mjpegstreamer target_fps: 15 target_fps_idle: 5 stream_url: http://ender3.somedomain.net/webcam/?action=stream snapshot_url: http://ender3.somedomain.net/webcam/?action=snapshot flip_horizontal: False flip_vertical: False rotation: 0 aspect_ratio: 4:3

[webcam camera_top] location: printer enabled: True service: mjpegstreamer target_fps: 15 target_fps_idle: 5 stream_url: http://ender3.somedomain.net/webcam2/?action=stream snapshot_url: http://ender3.somedomain.net/webcam2/?action=snapshot flip_horizontal: False flip_vertical: False rotation: 0 aspect_ratio: 16:9

When i comment(#) the webcam sections in the moonraker.conf file, reload moonraker. Than i can save the settings in mobileraker again.

Clon1998 commented 11 months ago

Thanks! I addressed that issue in e786db6 which will be included in the next release!

jelleh commented 11 months ago

Thanks!